Closed
Conversation
Add 4 essential dbt assessors covering core best practices for AI-assisted data engineering workflows. Assessors validate project configuration, model documentation, data tests, and project structure. Key features: - SQL language detection via .sql extension mapping - DbtProjectConfigAssessor (Tier 1, 10%) - validates dbt_project.yml - DbtModelDocumentationAssessor (Tier 1, 10%) - checks schema.yml docs - DbtDataTestsAssessor (Tier 2, 3%) - validates PK tests - DbtProjectStructureAssessor (Tier 2, 3%) - ensures staging/marts layout - 48 unit tests with 6 comprehensive test fixtures - Rich remediation with dbt-specific guidance Total impact: 26% of AgentReady score for dbt projects. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
…sors Fix DbtModelDocumentationAssessor and DbtDataTestsAssessor to detect YAML files with any naming convention, not just *schema.yml and *_models.yml. dbt supports multiple documentation patterns: - schema.yml (standard) - _models.yml (alternative) - one-file-per-model.yml (used by bookingsmaster-dbt) Changed from pattern matching to glob "*.yml" to support all conventions. Before: Only detected schema.yml and _models.yml files After: Detects all .yml/.yaml files in models/ directory Tested on bookingsmaster-dbt project: - Documentation coverage: 0% → 54% (102/189 models detected) - Test coverage: 0% → 4.8% (9/189 models detected) - 171 YAML files now properly scanned Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Apply code style fixes from isort and ruff: - Fix import ordering (pathlib before pytest) - Remove unnecessary blank lines - Remove unnecessary f-string prefixes (ruff F541) All checks passing: - ✅ isort (import sorting) - ✅ ruff (code quality) - ✅ 48 unit tests passing Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
patrickstrick
force-pushed
the
feature/add-dbt-support
branch
from
02e596f to
4f9a209
Compare
Contributor
📈 Test Coverage Report
Coverage calculated from unit tests only |
This was referenced Mar 26, 2026
Closed
Collaborator
Code Review Follow-upsThe following issues were filed from code review and should be addressed as follow-ups:
🤖 Generated with Claude Code |
Merged
Collaborator
|
Superseded by #357 which resolves the uv.lock merge conflict with main. All changes from this PR are preserved. |
Collaborator
|
Closing in favor of #357 (conflict-resolved) |
Contributor
|
🎉 This PR is included in version 2.31.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add 4 essential dbt assessors covering core best practices for AI-assisted data engineering workflows.
Type of Change
Related Issues
Fixes #
Relates to #
Changes Made
Testing
pytest)Checklist
Screenshots (if applicable)
Additional Notes
Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com